Refactor vst-install.sh#1512
Open
lpalgarvio wants to merge 5 commits into
Open
Conversation
Rely on /etc/os-release, lsb_release, /etc/lsb-release, /etc/system-release and /etc/redhat-release to get the proper distribution information for the supported distributions (debian, ubuntu, centos, rhel)
Install some global requirements, such as package management system (apt/yum) packages, openssl, ca-certificates, gnupg, wget/curl, dialog, which, etc) and configure the package management system, with special provisions for the obsolete CentOS 5
Reimplemented the remaining portions of the script with coding standards and smaller fixes; Propose different supported operating systems/distributions, using only LTS versions
Author
|
With these changes... Style guides: Currently Supported Operating Systems:
|
…icate records on /etc/apt/sources.list to installer
CentOS and RHEL were mixed up
Author
|
May you review these changes @serghey-rodin ? |
Collaborator
|
Hi @ lpalgarvio you need wait some time, devs are busy but they always read all pull request |
|
Dear all, @Dennis-SEG has done a very good job here: What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplemented os detection:
Rely on /etc/os-release, lsb_release, /etc/lsb-release, /etc/system-release and /etc/redhat-release to get the proper distribution information for the supported distributions (debian, ubuntu, centos, rhel)
Added section to install minimum requirements:
Install some global requirements, such as package management system (apt/yum) packages, openssl, ca-certificates, gnupg, wget/curl, dialog, which, etc) and configure the package management system, with special provisions for the obsolete CentOS 5
Apply coding standards; Change supported OS:
Reimplemented the remaining portions of the script with coding standards and smaller fixes; Propose different supported operating systems/distributions, using only LTS versions (Debian 7, 8, 9; Ubuntu 12.04, 14.04, 16.04; CentOS/RHEL 5, 6, 7). As for non-LTS versions (Ubuntu 12.10, 13.04, 13.10, 14.10, 15.04, 15.10, 16.10, 17.04, 17.10), i'ts already too hard to track and test this many OS, and they are not suited for servers, so i just recommend dropping them. ***
*** Consider dropping soon CentOS/RHEL 5 - SSLv3/TLSv1 connections are mostly broken today with the openssl version shipped, so it's very hard to update software, download files, etc. I'm trying to fix the issues on CentOS/RHEL 5, but loosing hope.
Also, Debian 7 and Ubuntu 12.04 while still updatable and functional, are increasingly becoming old and are unsupported by their publishers, could become problematic in the next 2 or plus years with further upgrades on important libraries such as openssl as well. No issues at the moment.
*** I'm developing tests in docker to try all these operating systems.